Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MPI Comm and Info leak in H5FD__mpio_delete #1189

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix MPI Comm and Info leak in H5FD__mpio_delete #1189

merged 1 commit into from
Nov 12, 2021

Conversation

jhendersonHDF
Copy link
Collaborator

No description provided.

@soumagne
Copy link
Member

I feel like you're missing an if comm not equal to comm world or comm null though.

@jhendersonHDF
Copy link
Collaborator Author

I feel like you're missing an if comm not equal to comm world or comm null though.

We updated the two routines a while back to check against MPI_COMM_WORLD, MPI_COMM_NULL and MPI_INFO_NULL before freeing the objects, so this should be ok.

@lrknox lrknox merged commit b9da39d into HDFGroup:develop Nov 12, 2021
@jhendersonHDF jhendersonHDF deleted the H5FD__mpio_delete_comm_leak branch January 12, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derobins derobins derobins approved these changes

@soumagne soumagne soumagne approved these changes

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jrmainzer jrmainzer Awaiting requested review from jrmainzer

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhendersonHDF @soumagne @derobins @lrknox