OESS-168: Remove clang warnings.

[hyoklee]

H5Lint.c:599:32: warning: cast from 'const char *' to 'char *' drops const qualifie\
r [-Wcast-qual]
    udata->lnk->name = (char *)name;
                               ^
H5Lint.c:1379:32: warning: cast from 'const char *' to 'char *' drops const qualifi\
er [-Wcast-qual]
    udata->lnk->name = (char *)name;

[jhendersonHDF]

Since these changes are in callbacks, it sort of seems like doing a strdup each time probably wouldn't be optimal. This seems like the kind of thing that needs to be fixed somewhere higher up where we correctly differentiate between when the link name should be const and non-const.

If we do go with this change though, the strdup calls should be changed to HDstrdup, or even better, HDstrndup.

[hyoklee]

HDstrndup() is not available in H5private.h.
strndup() is not available for MS VS C compiler.
Thus, I replaced strdup() with HDstrdup().

[qkoziol]

Since these changes are in callbacks, it sort of seems like doing a strdup each time probably wouldn't be optimal. This seems like the kind of thing that needs to be fixed somewhere higher up where we correctly differentiate between when the link name should be const and non-const.

Agree

[derobins]

The strdup is probably too much overhead for simply squashing a warning.