Brings changes to ttsafe_attr_vlen.c from develop #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for exposed pthreads code that causes Windows builds to fail.
derobins
requested review from
fortnern,
jhendersonHDF,
jrmainzer,
soumagne and
vchoi-hdfgroup
as code owners
derobins
commented
Dec 18, 2020
test/ttsafe_attr_vlen.c
Outdated
| @@ -6,7 +6,7 @@ | |||
| * This file is part of HDF5. The full HDF5 copyright notice, including * | |||
| * terms governing use, modification, and redistribution, is contained in * | |||
| * the COPYING file, which can be found at the root of the source code * | |||
| * distribution tree, or in https://www.hdfgroup.org/licenses. * | |||
| * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * | |||
There was a problem hiding this comment.
Should I change this back? I just copied the entire file over from develop.
There was a problem hiding this comment.
Yes, it should be the line ending in "licenses." I'll be updating develop in the near future.
lrknox
approved these changes
Dec 18, 2020
test/ttsafe_attr_vlen.c
Outdated
| @@ -6,7 +6,7 @@ | |||
| * This file is part of HDF5. The full HDF5 copyright notice, including * | |||
| * terms governing use, modification, and redistribution, is contained in * | |||
| * the COPYING file, which can be found at the root of the source code * | |||
| * distribution tree, or in https://www.hdfgroup.org/licenses. * | |||
| * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * | |||
There was a problem hiding this comment.
Yes, it should be the line ending in "licenses." I'll be updating develop in the near future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for exposed pthreads code that causes Windows builds to fail.