-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.12: Brings the updated CI in from develop #2311
Merged
derobins
merged 5 commits into
HDFGroup:hdf5_1_12
from
derobins:github_action_fixes_1_12
Dec 16, 2022
Merged
1.12: Brings the updated CI in from develop #2311
derobins
merged 5 commits into
HDFGroup:hdf5_1_12
from
derobins:github_action_fixes_1_12
Dec 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not include the -Werror checks, changes 1.14 API to 1.12 where needed.
byrnHDF
approved these changes
Dec 16, 2022
hyoklee
requested changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI fails so I don't have to review further until everything passes.
Looks like it's a bug in the mirror VFD. I think we also tripped over this in develop. I'll fix it. |
derobins
requested review from
jhendersonHDF,
soumagne,
vchoi-hdfgroup,
ChristopherHogan and
jrmainzer
as code owners
December 16, 2022 15:37
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Oct 5, 2023
* Brings the updated CI in from develop Does not include the -Werror checks, changes 1.14 API to 1.12 where needed. * Fixes an API compat issue in the mirror VFD test * Committing clang-format changes * Removed pr-check.yml Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not include the -Werror checks, changes 1.14 API to 1.12 where needed.