Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port h5dchunk_iter_hsizet_size #2074 to hdf5_1_12 branch #2329

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Port h5dchunk_iter_hsizet_size #2074 to hdf5_1_12 branch #2329

merged 3 commits into from
Mar 29, 2023

Conversation

mkitti
Copy link
Contributor

@mkitti mkitti commented Dec 20, 2022

cc: @derobins

@mkitti
Align arg types of H5D_chunk_iter_op_t with H5Dget_chunk_info (HDFGro…
4868233 
…up#2074)

* Align arg types of H5D_chunk_iter_op_t with H5Dget_chunk_info

* Modify chunk_info test to for unsigned / hsize_t types

* Fix types in test

* Port of HDFGroup#2074 to hdf5_1_12 branch
@mkitti mkitti mentioned this pull request Dec 20, 2022
Merged
@derobins
Copy link
Member

The failed test was due to the mirror VFD test not being able to connect to a socket. We see this test failure on GitHub from time to time. Re-running the failed tests fixes the problem so we think it's a GitHub issue.

@derobins derobins added the Merge Use this label when a PR is for a downstream merge label Dec 20, 2022
@mkitti
Copy link
Contributor Author

mkitti commented Jan 1, 2023

Note that we should also update the doxygen example as in #2380

jhendersonHDF
jhendersonHDF reviewed Feb 22, 2023
View reviewed changes
src/H5D.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@jhendersonHDF jhendersonHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me here; just minor nitpicks

@mkitti
Copy link
Contributor Author

mkitti commented Feb 22, 2023

Could we have some determination on #2380 ? I would prefer to keep the documentation in sync with the code if possible.

@jhendersonHDF
Copy link
Collaborator

jhendersonHDF commented Feb 22, 2023 •
edited
Loading

Could we have some determination on #2380 ? I would prefer to keep the documentation in sync with the code if possible.

That's probably more of a question for @derobins or @byrnHDF, but I'll note that to address that first warning the example should probably use the PRIuHSIZE macro in H5public.h to print out the hsize_t value rather than %ld

mkitti added a commit to mkitti/hdf5 that referenced this pull request Mar 6, 2023
@mkitti
Remove redundant and flawed documentation of H5D_chunk_iter_op_t from…
dce9714 
… H5D.c

Forward port of 9f252f1 from HDFGroup#2329
This was referenced Mar 6, 2023
Merged
Merged
@mkitti
Copy link
Contributor Author

mkitti commented Mar 8, 2023

I plan on pulling the Doxygen example correction from https://github.com/HDFGroup/hdf5/pull/2380/files#diff-a8a358e3ee19fd11ac351047b6fd4d25f291254c986970da70fbbebb69d0ce39 into this pull request, without the changes to cmake.

@mkitti
Copy link
Contributor Author

mkitti commented Mar 8, 2023

I cherry picked ef3bed6 into this branch for consistency. Minimal pull request to develop is #2519 .

lrknox pushed a commit that referenced this pull request Mar 8, 2023
@mkitti
Remove redundant and flawed documentation of H5D_chunk_iter_op_t from…
9884e18 
… H5D.c (#2512)

Forward port of 9f252f1 from #2329
@mkitti mkitti mentioned this pull request Mar 8, 2023
Closed
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Mar 15, 2023
@mkitti @lrknox
Remove redundant and flawed documentation of H5D_chunk_iter_op_t from…
99be145 
… H5D.c (HDFGroup#2512)

Forward port of 9f252f1 from HDFGroup#2329
@lrknox lrknox mentioned this pull request Mar 15, 2023
Merged
lrknox added a commit that referenced this pull request Mar 15, 2023
@lrknox @mkitti
Remove redundant and flawed documentation of H5D_chunk_iter_op_t from…
f24debb 
… H5D.c (#2512) (#2566)

Forward port of 9f252f1 from #2329

Co-authored-by: Mark Kittisopikul <mkitti@users.noreply.github.com>
@lrknox lrknox merged commit da9310d into HDFGroup:hdf5_1_12 Mar 29, 2023
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request May 17, 2023
@mkitti @brtnfld
Remove redundant and flawed documentation of H5D_chunk_iter_op_t from…
bb8f151 
… H5D.c (HDFGroup#2512)

Forward port of 9f252f1 from HDFGroup#2329
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 5, 2023
@mkitti @brtnfld
Port h5dchunk_iter_hsizet_size HDFGroup#2074 to hdf5_1_12 branch (HDF…
134088c 
…Group#2329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@soumagne soumagne Awaiting requested review from soumagne

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@ChristopherHogan ChristopherHogan Awaiting requested review from ChristopherHogan

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@jrmainzer jrmainzer Awaiting requested review from jrmainzer

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@fortnern fortnern

@jhendersonHDF jhendersonHDF

Labels
Merge Use this label when a PR is for a downstream merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mkitti @derobins @jhendersonHDF @byrnHDF @lrknox @fortnern