Include shlwapi.h explicitly on Windows

[mkitti]

This fixes builds on mingw32 and other compilers.

I suspect this will fix #2396 , #2408

[mkitti]

xref: https://learn.microsoft.com/en-us/windows/win32/api/shlwapi/nf-shlwapi-strstria

[mkitti]

Hmm, this alone may not be sufficient. shlwapi may also needed to be added to LINK_LIB when the header is detected. Testing again.

edit: d300feb is sufficient, I just forgot to apply the patch.

[mkitti]

During configuration this still occurs in the mingw32 environment.

-- Looking for StrStrIA in shlwapi;m;ws2_32;wsock32
-- Looking for StrStrIA in shlwapi;m;ws2_32;wsock32 - not found

This is due to name mangling that occurs in 32-bit windows with stdcall:

$ nm /mingw64/lib/libshlwapi.a  | grep StrStrIA
0000000000000000 I __imp_StrStrIA
0000000000000000 T StrStrIA

$ nm /mingw32/lib/libshlwapi.a  | grep StrStrIA
00000000 I __imp__StrStrIA@8
00000000 T _StrStrIA@8

[hmaarrfk]

Do you think it cleanly applies to 1.14.0?
If so I'm going to test it in conda-forge/hdf5-feedstock#188 if that is ok.

[hmaarrfk]

I can confirm that this fixes things for the "windows" compiler, at least in terms of the segfault.

[hmaarrfk]

didn't you want to fix the mingw32 configuration?

[mkitti]

didn't you want to fix the mingw32 configuration?

This addresses the issues for Windows-based compilation in general actually. Was there something else that needed to be addressed here?

[hmaarrfk]

No. I'm just glad I got to test the fix before you merged anything.

[emmenlau]

I think this PR opened a problem, because shlwapi is now a transitive dependency of hdf5, but this is not exposed via the cmake properties. Linking hdf5 on Windows leads to errors that can be resolved by linking shlwapi. But in cmake world, this dependency should be exposed from the cmake target.

So, since this commit, the following is no longer sufficient to link hdf5 for me:

  find_package(HDF5 MODULE REQUIRED COMPONENTS C)

  target_include_directories(libdeps SYSTEM INTERFACE ${HDF5_INCLUDE_DIRS})
  target_link_libraries(libdeps INTERFACE ${HDF5_C_LIBRARIES}) 
  target_compile_definitions(libdeps INTERFACE ${HDF5_DEFINITIONS})

[mkitti]

@emmenlau I think the problem would be easier to track if to created a new issue.