Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for CMake code and install docs #2623

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Minor fixes for CMake code and install docs #2623

merged 1 commit into from
Apr 3, 2023

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Mar 23, 2023

No description provided.

@byrnHDF byrnHDF added Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - Documentation Doxygen, markdown, etc. Component - Build CMake, Autotools Type - Task Actions that don't fit into any other type category labels Mar 23, 2023
@byrnHDF byrnHDF self-assigned this Mar 23, 2023
@brtnfld
Copy link
Contributor

brtnfld commented Apr 3, 2023

Why not just use "XX" or something for the 1.# versions, similar to using the 1.15."X" now, instead of continually updating these values in the docs?

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Apr 3, 2023 •
edited
Loading

Why not just use "XX" or something for the 1.# versions, similar to using the 1.15."X" now, instead of continually updating these values in the docs?
The major number only should be updated once. And it should be done automatically anyway.

@lrknox
Copy link
Collaborator

lrknox commented Apr 3, 2023

Why not just use "XX" or something for the 1.# versions, similar to using the 1.15."X" now, instead of continually updating these values in the docs?
The major number only should be updated once. And it should be done automatically anyway.

Doing it automatically could probably be done by h5vers. If you want to do it that way, I suggest an issue and a PR in the near future to do it, but to go ahead with the changes in this PR for now.

@derobins
Copy link
Member

derobins commented Apr 3, 2023

Agree with Scot's comment, but this is okay for now.

@derobins derobins merged commit 526f076 into HDFGroup:develop Apr 3, 2023
@byrnHDF byrnHDF deleted the develop-cmake-fixes branch April 28, 2023 15:56
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request May 17, 2023
@byrnHDF @brtnfld
Minor fixes for CMake code and install docs (HDFGroup#2623)
f2906fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derobins derobins derobins approved these changes

@lrknox lrknox lrknox approved these changes

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Documentation Doxygen, markdown, etc. Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Task Actions that don't fit into any other type category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@byrnHDF @brtnfld @lrknox @derobins