Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid suppressing error output for non-tentative file opens #2632

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Avoid suppressing error output for non-tentative file opens #2632

merged 2 commits into from
Apr 1, 2023

Conversation

jhendersonHDF
Copy link
Collaborator

No description provided.

@jhendersonHDF jhendersonHDF added Merge - To 1.12 Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - C Library Core C library issues (usually in the src directory) Type - Improvement Improvements that don't add a new feature or functionality labels Mar 24, 2023
qkoziol
qkoziol requested changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@qkoziol qkoziol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is good here, but the changes here and code in the existing next 'if' block should be integrated into one coherent set of code, instead of overlapping / duplicating code.

@jhendersonHDF
Copy link
Collaborator Author

@qkoziol Does that look a little better? I'm not super fond of the organization but it was the only way I could think of since we can't really conditionally use H5E_BEGIN/END_TRY without duplicating code.

qkoziol
qkoziol approved these changes Mar 26, 2023
View reviewed changes
Copy link
Contributor

@qkoziol qkoziol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads better and the code is clearer now, thanks for tuning it up!

@lrknox lrknox merged commit d3d1a03 into HDFGroup:develop Apr 1, 2023
jhendersonHDF added a commit to jhendersonHDF/hdf5 that referenced this pull request Apr 5, 2023
@jhendersonHDF
Avoid suppressing error output for non-tentative file opens (HDFGroup…
01e9a27 
…#2632)

* Avoid suppressing error output for non-tentative file opens

* Update comment about tentative file opens
jhendersonHDF added a commit to jhendersonHDF/hdf5 that referenced this pull request Apr 5, 2023
@jhendersonHDF
Avoid suppressing error output for non-tentative file opens (HDFGroup…
1d4c647 
…#2632)

* Avoid suppressing error output for non-tentative file opens

* Update comment about tentative file opens
jhendersonHDF added a commit to jhendersonHDF/hdf5 that referenced this pull request Apr 5, 2023
@jhendersonHDF
Avoid suppressing error output for non-tentative file opens (HDFGroup…
3266e14 
…#2632)

* Avoid suppressing error output for non-tentative file opens

* Update comment about tentative file opens
lrknox pushed a commit that referenced this pull request Apr 8, 2023
@jhendersonHDF
[1.10 Merge] Avoid suppressing error output for non-tentative file op…
3e689af 
…ens (#2632) (#2668)
derobins pushed a commit that referenced this pull request Apr 13, 2023
@jhendersonHDF
Avoid suppressing error output for non-tentative file opens (#2632) (#…
1d4c9ac 
…2669)

* Avoid suppressing error output for non-tentative file opens

* Update comment about tentative file opens
derobins pushed a commit that referenced this pull request Apr 13, 2023
@jhendersonHDF
Avoid suppressing error output for non-tentative file opens (#2632) (#…
8d9e964 
…2670)

* Avoid suppressing error output for non-tentative file opens

* Update comment about tentative file opens
@jhendersonHDF jhendersonHDF deleted the H5F_open_err_suppress branch April 17, 2023 20:03
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request May 17, 2023
@jhendersonHDF @brtnfld
Avoid suppressing error output for non-tentative file opens (HDFGroup…
602449b 
…#2632)

* Avoid suppressing error output for non-tentative file opens

* Update comment about tentative file opens
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 5, 2023
@jhendersonHDF @brtnfld
Avoid suppressing error output for non-tentative file opens (HDFGroup…
f910b82 
…#2632) (HDFGroup#2669)

* Avoid suppressing error output for non-tentative file opens

* Update comment about tentative file opens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkoziol qkoziol qkoziol approved these changes

@lrknox lrknox lrknox approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
Downstream HDF5 Merges
Status: Merges Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhendersonHDF @qkoziol @lrknox