Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code hidden behind #ifdef LATER #2686

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Remove dead code hidden behind #ifdef LATER #2686

merged 2 commits into from
Apr 10, 2023

Conversation

derobins
Copy link
Member

@derobins derobins commented Apr 8, 2023

No description provided.

@derobins derobins added Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Merge - To 1.12 Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - C Library Core C library issues (usually in the src directory) Component - Tools Command-line tools like h5dump, includes high-level tools Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately labels Apr 8, 2023
@derobins derobins removed the Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) label Apr 8, 2023
@derobins derobins merged commit 1ad030f into HDFGroup:develop Apr 10, 2023
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Apr 13, 2023
@derobins @brtnfld
Remove dead code hidden behind #ifdef LATER (HDFGroup#2686)
4092149
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request May 17, 2023
@derobins @brtnfld
Remove dead code hidden behind #ifdef LATER (HDFGroup#2686)
364b8b4
@derobins derobins deleted the yank_later branch March 27, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkoziol qkoziol qkoziol approved these changes

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@bmribler bmribler bmribler approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Component - Tools Command-line tools like h5dump, includes high-level tools Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Type - Improvement Improvements that don't add a new feature or functionality
Projects
Downstream HDF5 Merges
Status: Merge to 1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@derobins @qkoziol @jhendersonHDF @bmribler @byrnHDF