Clean up memory allocated when reading messages in H5Dlayout on error (#2602) #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsong09
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
mattjala and
brtnfld
as code owners
derobins
reviewed
Apr 10, 2023
src/H5Dlayout.c
Outdated
| hbool_t layout_copied = FALSE; /* Flag to indicate that layout message was copied */ | ||
| herr_t ret_value = SUCCEED; /* Return value */ | ||
| htri_t msg_exists; /* Whether a particular type of message exists */ | ||
| hbool_t dcpl_cache_pline_copied = FALSE; /* Flag to indicate that dcpl_cache.pline's message was copied */ |
There was a problem hiding this comment.
It's a small thing, but I would make the naming scheme consistent, probably by dropping the dcpl_cache from the name of this identifier.
derobins
approved these changes
Apr 10, 2023
|
I will make the change. |
|
Also, please add an entry in release_docs/RELEASE.txt with a short description of the issue and fix. Otherwise this looks good to me. |
Oh yeah, forgot to emphasize that. Should definitely do that. |
added 2 commits
April 11, 2023 07:24
… layout_fix Add note to release doc.
derobins
reviewed
Apr 11, 2023
release_docs/RELEASE.txt
Outdated
| @@ -151,6 +151,12 @@ Bug Fixes since HDF5-1.13.3 release | |||
| =================================== | |||
| Library | |||
| ------- | |||
| - Fixed memory leaks that could occur when reading a dataset from a malformed file | |||
|
|
|||
| When attempting to read layout, pline, and efl information for a dataset, memory leaks could occur if attempting to read pline/efl information threw an error, which is due to the memory that was allocated for pline and efl not being properly cleaned up on error. | |||
There was a problem hiding this comment.
This should wrap on 75-ish characters
lrknox
approved these changes
Apr 11, 2023
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Apr 13, 2023
byrnHDF
pushed a commit
to byrnHDF/hdf5
that referenced
this pull request
Apr 16, 2023
jhendersonHDF
added
Merge - To 1.14
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.