Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge with develop #2790

Merged
merged 11 commits into from
Apr 22, 2023
Merged

Merge with develop #2790

merged 11 commits into from
Apr 22, 2023

Conversation

derobins
Copy link
Member

No description provided.

@derobins derobins added Good First Issue Good for newcomers Merge Use this label when a PR is for a downstream merge Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - C Library Core C library issues (usually in the src directory) Component - Tools Command-line tools like h5dump, includes high-level tools Component - High-Level Library Code in the hl directory Component - Documentation Doxygen, markdown, etc. Component - Java Java wrappers Component - Fortran Fortran wrappers Component - C++ C++ wrappers Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Component - Build CMake, Autotools Type - Task Actions that don't fit into any other type category Component - Misc Anything else (CODEOWNERS, etc.) labels Apr 21, 2023
byrnHDF
byrnHDF reviewed Apr 21, 2023
View reviewed changes
bin/make_vers Outdated Show resolved Hide resolved
derobins
derobins commented Apr 21, 2023
View reviewed changes
bin/make_vers Outdated Show resolved Hide resolved
byrnHDF
byrnHDF reviewed Apr 21, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@derobins
Copy link
Member Author

All the issues have been fixed, but I haven't dug deeper into looking for additional issues. I'll work on that this afternoon.

jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
src/H5Fsuper.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
src/H5Ofill.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
src/H5Ofsinfo.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
src/H5Oint.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
src/H5Opline.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
src/H5S.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
src/H5Shyper.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
src/H5Spoint.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
src/H5T.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
src/H5trace.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
test/chunk_info.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 21, 2023
View reviewed changes
test/h5test.c Outdated Show resolved Hide resolved
lrknox
lrknox reviewed Apr 21, 2023
View reviewed changes
tools/test/h5repack/testfiles/h5repack-help.txt Outdated Show resolved Hide resolved
tools/src/h5repack/h5repack_main.c Outdated Show resolved Hide resolved
test/tfile.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 22, 2023
View reviewed changes
examples/testh5cc.sh.in Outdated
echo "Testing HDF5 with 114_API_DEFAULT"
TOOLTEST -DH5_USE_16_API_DEFAULT $v16main
TOOLTEST -DH5_USE_18_API_DEFAULT $v18main
TOOLTEST -DH5_USE_110_API_DEFAULT $v110main
TOOLTEST -DH5_USE_112_API_DEFAULT $v112main
TOOLTEST $v114main
else
echo "Testing HDF5 with 116_API_DEFAULT"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this else block as a whole, but 116 is mentioned here

@derobins derobins merged commit 7707859 into HDFGroup:hdf5_1_14 Apr 22, 2023
@mkitti mkitti mentioned this pull request May 10, 2023
Merged
3 tasks
@derobins derobins deleted the 1_14_merge_w_develop branch March 27, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox lrknox left review comments

@byrnHDF byrnHDF byrnHDF left review comments

@brtnfld brtnfld brtnfld approved these changes

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@bmribler bmribler bmribler approved these changes

@epourmal epourmal Awaiting requested review from epourmal epourmal is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

Assignees
No one assigned
Labels
Component - Build CMake, Autotools Component - C Library Core C library issues (usually in the src directory) Component - C++ C++ wrappers Component - Documentation Doxygen, markdown, etc. Component - Fortran Fortran wrappers Component - High-Level Library Code in the hl directory Component - Java Java wrappers Component - Misc Anything else (CODEOWNERS, etc.) Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Component - Tools Command-line tools like h5dump, includes high-level tools Good First Issue Good for newcomers Merge Use this label when a PR is for a downstream merge Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Task Actions that don't fit into any other type category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@derobins @bmribler @brtnfld @lrknox @jhendersonHDF @byrnHDF