Fix plugin cache variable name #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Merge - To 1.12
Merge - To 1.14
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
lrknox
approved these changes
May 19, 2023
config/cmake/HDF5PluginCache.cmake
Outdated
| @@ -8,7 +8,7 @@ | |||
| set (H5PL_BUILD_TESTING ON CACHE BOOL "Enable H5PL testing" FORCE) | |||
| set (BUILD_EXAMPLES ON CACHE BOOL "Build H5PL Examples" FORCE) | |||
|
|
|||
| set (HDF5_HDF5_HEADER "H5pubconf.h" CACHE STRING "Name of HDF5 header" FORCE) | |||
| set (H5PL_HDF5_HEADER "H5pubconf.h" CACHE STRING "Name of HDF5 header" FORCE) | |||
| set (HDF5_LINK_LIBS ${HDF5_LIBSH_TARGET} CACHE STRING "HDF5 target" FORCE) | |||
There was a problem hiding this comment.
I think this one also needs to be updated if I understand correctly.
There was a problem hiding this comment.
Maybe, I need to see where that is used but most likely it needs to be prefixed with "H5PL_"
jhendersonHDF
approved these changes
May 19, 2023
lrknox
reviewed
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires change in plugins project also