Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify. #3659

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Simplify. #3659

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21b7e12
Fix grammar.
hyoklee Oct 11, 2023
abde3a1
Address @jhendersonHDF review
hyoklee Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testpar/t_filters_parallel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ create_datasets(hid_t parent_obj_id, const char *dset_name, hid_t type_id, hid_t
dset_name_ptr = dset_name_multi_buf;
n_dsets = (rand() % (MAX_NUM_DSETS_MULTI - 1)) + 2;

/* Select between 1 and (n_dsets - 1) datasets to NOT be filtered */
/* Select between 1 and (n_dsets - 1) datasets to unfiltered */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to unfiltered -> to be unfiltered, but there's nothing wrong with the sentence as is now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, there is nothing grammatically incorrect with the current statement.

if (test_mode == USE_MULTIPLE_DATASETS_MIXED_FILTERED) {
n_unfiltered = (rand() % (n_dsets - 1)) + 1;

Expand Down