Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct fortran CMake generator expressions #3670

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Correct fortran CMake generator expressions #3670

merged 2 commits into from
Oct 14, 2023

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Oct 13, 2023 •
edited
Loading

This was in response to 3666 issue, but still needs to be corrected.

@byrnHDF byrnHDF added Merge - To 1.12 Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - Fortran Fortran wrappers Component - Build CMake, Autotools Type - Bug Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub labels Oct 13, 2023
@byrnHDF byrnHDF self-assigned this Oct 13, 2023
@hyoklee
Copy link
Member

hyoklee commented Oct 13, 2023 •
edited
Loading

It still fails with cmake -G Ninja -DHDF5_BUILD_FORTRAN:BOOL=ON -DHDF5_ENABLE_PARALLEL:BOOL=ON .. && ninja
on Monterey+clang17.0.2+gcc13.2.0+cmake 3.27.7

Undefined symbols for architecture x86_64:
  "_getenv_", referenced from:
      _MAIN__ in ph5example.f90.o
ld: symbol(s) not found for architecture x86_64
collect2: error: ld returned 1 exit status

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Oct 13, 2023

Then there is something else going on that needs to be fixed.

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Oct 13, 2023

This change still needs to be implemented.

@lrknox lrknox merged commit 405b0c6 into HDFGroup:develop Oct 14, 2023
39 checks passed
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 16, 2023
@byrnHDF @brtnfld
Correct fortran CMake generator expressions (HDFGroup#3670)
7340c69
jhendersonHDF pushed a commit to jhendersonHDF/hdf5 that referenced this pull request Oct 18, 2023
@byrnHDF @jhendersonHDF
Correct fortran CMake generator expressions (HDFGroup#3670)
442f15e
derobins added a commit that referenced this pull request Oct 18, 2023
@jhendersonHDF @brtnfld
@hyoklee @byrnHDF @derobins
Sync 1.14 branch with develop (#3705)
4a02890 
* Address nagfor exceptions stoppage. (#3658)

* added cmake ieee flag for nagfor

* generalized determining the nag compiler

* fixing some misc. NAG warnings

* Simplify. (#3659)


* Address @jhendersonHDF review

* Add expedited testing support to t_filters_parallel (#3665)

* Remove clang warnings (#3656)

* Fixes test failure for gfortran -O2 and -O3, -fdefault-real-16 (#3662)

* added cmake ieee flag for nagfor

* fixes gfortran -O2 and -O3, -fdefault-real-16

* fixed sync

* updated release notes

* Fix link error on clang17/gfortran13/macOS-13 (#3666) (#3671)

* Correct fortran CMake generator expressions (#3670)

* Add AOCC GitHub Action (#3504) (#3657)

* Fix uninitialized subfiling test variable (#3675)

Picked up by gcc 10 on skybridge. Probably spurious, but no harm in
initializing it to a "bad" value.

* Add support for AOCC & Flang w/ the Autotools (#3674)

* Adds a config/clang-fflags options file to support Flang
* Corrects missing "-Wl," from linker options in the libtool wrappers
  when using Flang, the MPI Fortran compiler wrappers, and building
  the shared library. This would often result in unrecognized options
  like -soname.
* Enable -nomp w/ Flang to avoid linking to the OpenMPI library.

CMake can build the parallel, shared library w/ Fortran using AOCC
and Flang, so no changes were needed for that build system.

Fixes GitHub issues #3439, #1588, #366, #280

* Fix a strncpy call to use dest size not src (#3677)

A strncpy call in a path construction call used the size of the src
buffer instead of the dest buffer as the limit n.

This was switched to use the dest size and properly terminate the
string if truncation occurs.

* Remove CANBE_UNUSED() from subfiling VFD (#3678)

This macro was an attempt to quiet warnings about release mode unused
variables that only appear in asserts. It resolves to a void cast, which
doesn't quiet warnings when an assignment has already taken place.

* Suppress MPI_Waitall warnings w/ MPICH (#3680)

MPICH defines MPI_STATUSES_IGNORE (a pointer) to 1, which raises warnings
w/ gcc. This is a known issue that the MPICH devs are not going to fix.

See here:
    pmodels/mpich#5687

This fix suppresses those issues w/ gcc

* Fix a possible NULL pointer dereference in tests (#3676)


The dtypes test could dereference a NULL pointer if a strdup call
failed.

* Fix printf warnings in t_mpi (#3679)

* Fix printf warnings in t_mpi

The type of MPI_Offset varies with implementation. In MPICH, it's long,
which raises warnings when we attempt to use long long format
specifiers. Casting to long long fixes the warnings.

* Fix invalid memory access in S3 comms (#3681)

In the ros3 VFD, passing an empty string parameter to an internal
API call could result in accessing the -1th element of a string.
This would cause failures on big-endian systems like s390x.

This parameter is now checked before writing to the string.

Fixes GitHub #1168

* Add Doxygen for H5Pset_fapl_sec2() (#3685)

*

* switch to using time function instead of date function (#3690)

* Initialize API context MPI types to MPI_BYTE (#3688)

* Add test info output to t_filters_parallel (#3696)

* Suppress format string warnings in subfiling test (#3699)

* Fix unused variable in tselect.c (#3701)

* Fix unused variable warning in H5F_sfile_assert_num (#3700)

* Restore floating-point suffixes in tests (#3698)

A prior commit removed too many F suffixes. This restores the suffixes
for float variables.

* Sync with changes from develop

---------

Co-authored-by: Scot Breitenfeld <brtnfld@hdfgroup.org>
Co-authored-by: H. Joe Lee <hyoklee@hdfgroup.org>
Co-authored-by: Allen Byrne <50328838+byrnHDF@users.noreply.github.com>
Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
@byrnHDF byrnHDF deleted the develop-fortran-cmake branch October 22, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derobins derobins derobins approved these changes

@hyoklee hyoklee hyoklee approved these changes

@lrknox lrknox lrknox approved these changes

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

@epourmal epourmal Awaiting requested review from epourmal epourmal is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Fortran Fortran wrappers Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Bug Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@byrnHDF @hyoklee @derobins @lrknox @jhendersonHDF