Primary change is HDFFV-11212 - new refs and JNI #372
Conversation
|
Updated h5util files with issues discovered. |
| hsize_t cnt_idx = 0; | ||
| hsize_t hs_idx = 0; | ||
| j = opts->rank - 1; | ||
| hsize_t prev_dim_size = 0; /* previous dim size */ |
There was a problem hiding this comment.
This is the code to convert a hyperslab contiguous index to the original index coordinates for the display output.
| @@ -76,7 +76,6 @@ check_options(diff_opt_t *opts) | |||
| } | |||
| } | |||
|
|
|||
| #if TRILABS_227 | |||
| /*------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Is this macro always defined now?
There was a problem hiding this comment.
No macro, just a code holder.
There was a problem hiding this comment.
So that code is active now?
There was a problem hiding this comment.
yes, most of it has been in for awhile, but I need to test it more widely.
There was a problem hiding this comment.
OK
Were you defining TRILABS_227 by hand then? Or was it in a configure option? Or ???
There was a problem hiding this comment.
It was a way to keep the code for the release and come back to it.
There was a problem hiding this comment.
Also, there was a refactor of h5diff functions that was triggered by the work and I just needed to merge for the release without losing working code.
There was a problem hiding this comment.
Was confusing (obviously! :-) - maybe put it on a branch next time?
java/test/TestH5Rref.java
Outdated
| @@ -0,0 +1,562 @@ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * | |||
| * Copyright by The HDF Group. * | |||
| * Copyright by the Board of Trustees of the University of Illinois. * | |||
There was a problem hiding this comment.
I think this is a new file? If so, it shouldn't have the line or the Board of Trustees. Also, the support URL 6 lines down should be replaced with " * distribution tree, or in https://www.hdfgroup.org/licenses. *"
There was a problem hiding this comment.
It was a split of TestH5R.java
There was a problem hiding this comment.
Actually all these java test files are new since like 2010.
Added tests for JNI export dataset and updated export for new refs.
See new src/hdf5lib/H5.java function, src/jni/ h5util.c(.h), test/TestH5.java and test/H5Rref.java.
Updated java hid_t initializations to H5_INVALID_ID instead of -1. All examples and java tests, plus src/jni/h5constants.c.
Removed unused argument to h5str_sprintf function in jni files; h5aimp.c and h5dimp.c.
Tools changes:
Corrected long double printf specifier from %Lf to %Lg in lib/h5tools_str.c.
Close id in lib/h5tools_dump.c.
Correct use of options->fout_fapl in src/h5repack/h5repack_copy.c and src/h5repack_verify.c.
lib/h5diff_array.c, updated latest h5diff subset code - tests remain disabled.