Revert "add doxygen to H5Ppublic.h" #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2ee1821.
gheber
requested review from
derobins,
fortnern,
jhendersonHDF,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
|
There are too many mistakes here. Let's not create a total mess. |
|
GitHub said it was ready to merge, based on default requirements of one approval and passing the required clang-format check.
Additional requirements can be set up for the branch in github actions, in a list for me to follow, including a simple “Don’t merge commits to doxygen2”.
Larry
From: Gerd Heber <notifications@github.com>
Sent: Thursday, February 25, 2021 8:06 PM
To: HDFGroup/hdf5 <hdf5@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [HDFGroup/hdf5] Revert "add doxygen to H5Ppublic.h" (#387)
Reverts #378<#378>
Why was this merged?
…________________________________
You can view, comment on, or merge this pull request online at:
#387
Commit Summary
* Revert "add doxygen to H5Ppublic.h (#378)"
File Changes
* M src/H5Ppublic.h<https://github.com/HDFGroup/hdf5/pull/387/files#diff-14a4aebec10e212a5392fbcd492223c000d2ca72615824ece81e91bd731a0d32> (1141)
Patch Links:
* https://github.com/HDFGroup/hdf5/pull/387.patch
* https://github.com/HDFGroup/hdf5/pull/387.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#387>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCVRGWRTIAQNI6HS42DTA36XFANCNFSM4YHS4BAA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #378
Why was this merged?