Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary step from REST VOL workflow #4331

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Remove unnecessary step from REST VOL workflow #4331

merged 1 commit into from
Apr 5, 2024

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Apr 4, 2024

HSDS isn't run through docker in this test, so stopall.sh isn't doing anything. It's also causing the workflow to fail now that docker-compose v1 isn't part of the runners by default anymore.

Successful run of the workflow without this step can be seen here

@mattjala mattjala added Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - Testing Code in test or testpar directories, GitHub workflows Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately labels Apr 4, 2024
@lrknox lrknox merged commit 88b640a into HDFGroup:develop Apr 5, 2024
58 checks passed
qkoziol pushed a commit to qkoziol/hdf5 that referenced this pull request Apr 8, 2024
@mattjala @qkoziol
Remove unnecessary step from REST VOL workflow (HDFGroup#4331)
3bb292e
@mattjala mattjala deleted the remove_hsds_shutdown branch September 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derobins derobins derobins approved these changes

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately
Projects
Downstream HDF5 Merges
Status: Needs Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattjala @derobins @jhendersonHDF @lrknox