Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run AOCC parallel tests with -j2 #4752

Merged
merged 4 commits into from
Aug 24, 2024
Merged

Don't run AOCC parallel tests with -j2 #4752

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6c4c9a
Don't run AOCC parallel tests with -j2
derobins Aug 23, 2024
9832025
Split off AOCC CMake parallel tests
derobins Aug 23, 2024
d475836
Remove unnecessary NPROCS env vars
derobins Aug 23, 2024
ac3df1b
Put NPROCS back in serial tests
derobins Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/aocc-auto.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,24 @@ jobs:
make -j3
working-directory: ${{ runner.workspace }}/build

# ph5diff tests are in the tools/tests directory so they will get run
# here
- name: Autotools Run Tests
env:
NPROCS: 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should NPROCS be unset here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be. It's not necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. We only use NPROCS in the parallel tests and configure (just in case).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, no - I'm putting it back in the serial tests since we run the ph5diff tests there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems worth reworking since they aren't serial tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, but I'll save that for a different PR.

run: |
export PATH=/home/runner/work/hdf5/hdf5/openmpi-4.1.6-install/bin:/usr/local/bin:$PATH
make check -j
cd test && make check -j2 && cd ..
cd tools && make check -j2 && cd ..
cd hl && make check -j2 && cd ..
working-directory: ${{ runner.workspace }}/build

- name: Autotools Run Parallel Tests
env:
NPROCS: 2
run: |
export PATH=/home/runner/work/hdf5/hdf5/openmpi-4.1.6-install/bin:/usr/local/bin:$PATH
cd testpar && make check && cd ..
working-directory: ${{ runner.workspace }}/build

- name: Autotools Install
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/aocc-cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,6 @@ jobs:
- name: CMake Run Tests
shell: bash
run: |
ctest . --parallel 2 -C ${{ inputs.build_mode }} -V
ctest . -E MPI_TEST --parallel 2 -C ${{ inputs.build_mode }} -V
ctest . -R MPI_TEST -C ${{ inputs.build_mode }} -V
working-directory: ${{ runner.workspace }}/build
Loading