Added more C++11 override keywords #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems I didn't get them all last time... I used a newer clang here and I think this is all of them finally. |
byrnHDF
approved these changes
Mar 21, 2021
|
Unfortunately, my confidence about these changes would be low. More in @bmribler 's wheelhouse than mine. :-) |
|
@bmribler if you're too busy, maybe you know of another C++ reviewer? |
bmribler
approved these changes
Apr 20, 2021
seanm
requested review from
fortnern,
jhendersonHDF,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
|
Great, thanks! Can these get into the 1.10.x branch too please? |
|
Yes, after a couple of days testing develop I’ll create pull requests to merge all recent pull requests that have been merged to develop but not to 1.12 and 1.10.
From: Sean McBride ***@***.***>
Sent: Wednesday, April 21, 2021 11:05 AM
To: HDFGroup/hdf5 ***@***.***>
Cc: Larry Knox ***@***.***>; State change ***@***.***>
Subject: Re: [HDFGroup/hdf5] Added more C++11 override keywords (#485)
Great, thanks! Can these get into the 1.10.x branch too please?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#485 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCWIHJPFUL7ABGPFGA3TJ3ZTVANCNFSM4ZPZZZEA>.
|
|
Will that require a higher C++ standard then what is already in 1.12. I know we changed the develop setting - not sure we can move 1.12 setting? |
|
No, because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.