Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add threadsafety warning doc #4877

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Add threadsafety warning doc #4877

merged 1 commit into from
Sep 26, 2024

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Sep 25, 2024 •
edited
Loading

This is largely a summary of a discussion with @qkoziol about how the library handles thread cleanup.

@mattjala mattjala added Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - Documentation Doxygen, markdown, etc. Type - Improvement Improvements that don't add a new feature or functionality labels Sep 25, 2024
@mattjala mattjala self-assigned this Sep 25, 2024
hyoklee
hyoklee approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@hyoklee hyoklee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a comma after each e.g. for National Punctuation Day (9/24)? 🙂

@lrknox lrknox merged commit e590960 into HDFGroup:develop Sep 26, 2024
2 checks passed
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Oct 2, 2024
@mattjala @lrknox
Add threadsafety warning doc (HDFGroup#4877)
45b0dcd
lrknox pushed a commit that referenced this pull request Oct 2, 2024
@mattjala @lrknox
Add threadsafety warning doc (#4877)
714731b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyoklee hyoklee hyoklee approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@mattjala mattjala

Labels
Component - Documentation Doxygen, markdown, etc. Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattjala @hyoklee @byrnHDF @lrknox