Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add call to AC_CHECK_SIZEOF([__float128]). #4924

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Re-add call to AC_CHECK_SIZEOF([__float128]). #4924

merged 1 commit into from
Oct 4, 2024

Conversation

opoplawski
Copy link
Contributor

Fixes #4916

@opoplawski
Copy link
Contributor Author

$ac_cv_sizeof___float128 is used later - and is undefined if this is not called.

@derobins derobins merged commit 0af668f into HDFGroup:develop Oct 4, 2024
60 checks passed
@derobins derobins added Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - Fortran Fortran wrappers Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality Merge - To 1.16 This needs to be merged to HDF5 1.16 labels Oct 4, 2024
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Oct 9, 2024
@opoplawski @lrknox
Re-add call to AC_CHECK_SIZEOF([__float128]). Fixes HDFGroup#4916. (H…
b866023 
…DFGroup#4924)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derobins derobins derobins approved these changes

@brtnfld brtnfld brtnfld approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

Assignees
No one assigned
Labels
Component - Build CMake, Autotools Component - Fortran Fortran wrappers Merge - To 1.14 This needs to be merged to HDF5 1.14 Merge - To 1.16 This needs to be merged to HDF5 1.16 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build faills on 32-bit Fedora Rawhide
3 participants
@opoplawski @derobins @brtnfld