Hdf5 merge issue 487 v110 #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a few testhdf5 warnings raised in Visual Studio Visual Studio is grumpier about treating pointers like integers than gcc. * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Suppresses the tcheck_version test's abort dialog on Windows Windows raises a modal abort/retry/ignore dialog box when CRT calls abort(). This change installs a report hook that suppresses the dialog so that the CMake tests don't time out waiting for a nonexistent user to click a dialog box. * Committing clang-format changes * Removes __cdecl from callback Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
lrknox
requested review from
bljhdf,
bmribler,
byrnHDF,
derobins,
fortnern,
jhendersonHDF,
jrmainzer,
rawarren,
soumagne and
vchoi-hdfgroup
as code owners
byrnHDF
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging changes from these PRs. Changes are in the 6 files listed. Changes in the other 116 files result from the clang config changes for clang-format.
473 Update clang config c6e4e53
(just the 3 clang configuration files -.clang-format and bin/gormat_source*)
475 Cleans up a couple of MSVC warnings in testhdf5 35d6091 1 files
(test/tselect.c)
476 Fix typos and grammar errors. 00a4e41 1 file
(release_docs/RELEASE.txt)
477 Suppresses the tcheck_version test's abort dialog on Windows d0f8075 1 file
(test/tcheck_version.c)