Hash table replacement for skip lists in ID code #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Can be switched between skip list and hash table implementation with H5_USE_ID_HASH_TABLE #define * Not yet updated to use iterate-safe delete
commented out.
…s/hdf5 into major/hash_table_ids_new
derobins
requested review from
fortnern,
jhendersonHDF,
jrmainzer,
lrknox and
qkoziol
as code owners
soumagne
reviewed
Apr 27, 2021
| */ | ||
| HDfprintf(stderr, " (HASH TABLE)\n"); | ||
| HASH_ITER(hh, type_info->hash_table, item, tmp) | ||
| { |
There was a problem hiding this comment.
Make sure you add that to clang-format as an iterator, that will fix the { }
lrknox
approved these changes
May 4, 2021
byrnHDF
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.