Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran target depends #608

Merged
merged 186 commits into from
Apr 30, 2021
Merged

Fortran target depends #608

merged 186 commits into from
Apr 30, 2021

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Apr 28, 2021

No description provided.

@byrnHDF byrnHDF self-assigned this Apr 28, 2021
@lrknox
Copy link
Collaborator

lrknox commented Apr 30, 2021

Error with NAG fortran compiler and GCC 10.2.0:

Warning: /mnt/wrk/lrknox/byrn-hdf5/fortran/src/H5_buildiface.F90, line 1074: C_CHAR explicitly imported into H5_BUILDIFACE but not used
Warning: /mnt/wrk/lrknox/byrn-hdf5/fortran/src/H5_buildiface.F90, line 1074: C_LOC explicitly imported into H5_BUILDIFACE but not used
Warning: /mnt/wrk/lrknox/byrn-hdf5/fortran/src/H5_buildiface.F90, line 1074: C_PTR explicitly imported into H5_BUILDIFACE but not used
Error: /mnt/wrk/lrknox/byrn-hdf5/fortran/src/H5_buildiface.F90, line 55: Dimension 1 of value for array RKIND has extent 1 instead of 0
[ 44%] Generating testfiles/w-ext-two-d.ddl
Errors in declarations, no further processing for H5_BUILDIFACE
[NAG Fortran Compiler error termination, 1 error, 3 warnings]
gmake[2]: *** [fortran/src/CMakeFiles/H5_buildiface.dir/H5_buildiface.F90.o] Error 2
NAG Fortran Compiler Release 7.0(Yurakucho) Build 7011
gmake[1]: *** [fortran/src/CMakeFiles/H5_buildiface.dir/all] Error 2

@brtnfld
Copy link
Contributor

brtnfld commented Apr 30, 2021

It looks to me that the H5_H5CONFIG_F_RKIND is not getting generated correctly during config. There seems to be an issue with num_rkinds detected in HDF5UseFortran.cmake

I'm assuming this change is the issue:

DEPENDS H5_buildiface ${f90_F_GEN_SOURCES}

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Apr 30, 2021

It looks to me that the H5_H5CONFIG_F_RKIND is not getting generated correctly during config. There seems to be an issue with num_rkinds detected in HDF5UseFortran.cmake

I'm assuming this change is the issue:

DEPENDS H5_buildiface ${f90_F_GEN_SOURCES}

DEPENDS just indicates the build order, config happens before build.

Copy link
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a separate issue with NAG, looks fine otherwise.

@lrknox lrknox merged commit 7ab9703 into HDFGroup:develop Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants