Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A batch of life-cycle examples for different modules #654

Merged
merged 118 commits into from
Sep 1, 2021
Merged

A batch of life-cycle examples for different modules #654

merged 118 commits into from
Sep 1, 2021

Conversation

gheber
Copy link
Member

@gheber gheber commented May 18, 2021

@gheber gheber requested a review from gnuoyd as a code owner August 19, 2021 13:42
Copy link
Contributor

@byrnHDF byrnHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There probably needs to be a Release.txt entry.
And we need to stop creating these large PRs. There are at least three ways to divide this; the configuration file, the source files and the dox files.

configure.ac Show resolved Hide resolved
@byrnHDF
Copy link
Contributor

byrnHDF commented Aug 30, 2021

Can all these changes be applied to 1.12 and 1.10 branches? Other then obvious version sections?

Copy link
Contributor

@byrnHDF byrnHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rework CMake doxygen after this is merged.

@lrknox lrknox merged commit cf25524 into HDFGroup:develop Sep 1, 2021
lrknox pushed a commit that referenced this pull request Sep 7, 2021
…988)

* Merge A batch of life-cycle examples for different modules #654

* Change doxygen generated file location
lrknox pushed a commit that referenced this pull request Sep 7, 2021
…987)

* Merge A batch of life-cycle examples for different modules #654

* Remove generated file

* Change doxygen generated file location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants