Brings chunk_info valgrind fix from 1.12 #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a minor valgrind issue in the chunk_info test The chunk_info test incorrectly set the number of bytes in a compressed buffer, which caused valgrind to complain about writing uninitialized bytes. * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
derobins
requested review from
fortnern,
jhendersonHDF,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
lrknox
approved these changes
May 22, 2021
byrnHDF
approved these changes
May 22, 2021
derobins
commented
May 23, 2021
| @@ -544,14 +544,15 @@ test_get_chunk_info_highest_v18(hid_t fapl) | |||
| /* Allocate input (compressed) buffer */ | |||
| inbuf = HDcalloc(1, z_dst_nbytes); | |||
There was a problem hiding this comment.
Using calloc here quiets valgrind's 'uninitialized bytes' warning (1.12 used malloc), but still writes the larger, incorrect number of bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes uninitialized bytes alert from valgrind caused by not updating the buffer size after running compress2.