Changes to docs for using plugins #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
bmribler,
derobins,
lrknox and
qkoziol
as code owners
bmribler
reviewed
Jul 1, 2021
bin/release
Outdated
| @@ -229,11 +229,14 @@ tar2cmakezip() | |||
| (cd $cmziptmpsubdir; echo "ctest -S HDF5config.cmake,BUILD_GENERATOR=VS201564 -C Release -V -O hdf5.log" > build-VS2015-64.bat; chmod 755 build-VS2015-64.bat) | |||
| (cd $cmziptmpsubdir; echo "ctest -S HDF5config.cmake,BUILD_GENERATOR=VS2017 -C Release -V -O hdf5.log" > build-VS2017-32.bat; chmod 755 build-VS2017-32.bat) | |||
| (cd $cmziptmpsubdir; echo "ctest -S HDF5config.cmake,BUILD_GENERATOR=VS201764 -C Release -V -O hdf5.log" > build-VS2017-64.bat; chmod 755 build-VS2017-64.bat) | |||
| (cd $cmziptmpsubdir; echo "ctest -S HDF5config.cmake,BUILD_GENERATOR=VS2019 -C Release -V -O hdf5.log" > build-VS2019-32.bat; chmod 755 build-VS2017-32.bat) | |||
| (cd $cmziptmpsubdir; echo "ctest -S HDF5config.cmake,BUILD_GENERATOR=VS201964 -C Release -V -O hdf5.log" > build-VS2019-64.bat; chmod 755 build-VS2017-64.bat) | |||
There was a problem hiding this comment.
Is the VS2017 to the far right really meant to be 2017?
bmribler
reviewed
Jul 1, 2021
| HDF5_DIR=C:/Program Files/HDF_Group/HDF5/1.13.x/cmake | ||
| On unix: | ||
| HDF5_DIR=<install root folder>/HDF_Group/HDF5/1.13.x/cmake |
There was a problem hiding this comment.
1.13 is the current version of develop.
lrknox
approved these changes
Jul 1, 2021
| @@ -163,7 +163,7 @@ if (NOT DEFINED HPC) | |||
| set (SITE_COMPILER_NAME "vs2012") | |||
| set (SITE_COMPILER_VERSION "11") | |||
| else () | |||
| message (FATAL_ERROR "Invalid BUILD_GENERATOR must be - Unix, VS2017, or VS201764, VS2015, VS201564, VS2013, VS201364") | |||
| message (FATAL_ERROR "Invalid BUILD_GENERATOR must be - Unix VS2019, VS201964, VS2017, or VS201764, VS2015, VS201564,") | |||
There was a problem hiding this comment.
comma should be removed at end, 'or' moved to before 'VS201664', and comma missing after 'Unix'?
Suggested change
| message (FATAL_ERROR "Invalid BUILD_GENERATOR must be - Unix VS2019, VS201964, VS2017, or VS201764, VS2015, VS201564,") | |
| message (FATAL_ERROR "Invalid BUILD_GENERATOR must be - Unix, VS2019, VS201964, VS2017, VS201764, VS2015, or VS201564") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.