Added int variable for comparison with H5_VERS_RELEASE in H5.c to avoid #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning that unsigned comparison < 0 is always false, which is known,
but for later versions the comparison can possibly be true.
lrknox
requested review from
derobins,
fortnern,
jhendersonHDF,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
derobins
approved these changes
Jul 29, 2021
jhendersonHDF
approved these changes
Jul 29, 2021
byrnHDF
reviewed
Jul 30, 2021
| @@ -912,6 +912,8 @@ H5check_version(unsigned majnum, unsigned minnum, unsigned relnum) | |||
| static unsigned int disable_version_check = 0; /* Set if the version check should be disabled */ | |||
| static const char * version_mismatch_warning = VERSION_MISMATCH_WARNING; | |||
| herr_t ret_value = SUCCEED; /* Return value */ | |||
| int releasenum = relnum; /* To avoid warning for unsigned < 0 | |||
There was a problem hiding this comment.
This does not make sense to me. Basically your're setting an int from an unsigned int?
What is H5_VERS_RELEASE defined as? Would a cast work? H5_VERS_RELEASE > (int)relnum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warning that unsigned comparison < 0 is always false, which is known,
but for later versions the comparison can possibly be true.