Fix clang/sanitizer for windows #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derobins
reviewed
Aug 6, 2021
| @@ -83,7 +83,7 @@ if(USE_SANITIZER) | |||
| elseif(MSVC) | |||
| if(USE_SANITIZER MATCHES "([Aa]ddress)") | |||
| message(STATUS "Building with Address sanitizer") | |||
| append("-fsanitize=address" CMAKE_C_SANITIZER_FLAGS CMAKE_CXX_SANITIZER_FLAGS) | |||
| append("/fsanitize=address" CMAKE_C_SANITIZER_FLAGS CMAKE_CXX_SANITIZER_FLAGS) | |||
There was a problem hiding this comment.
This should be restricted to VS 2019 16.9
There was a problem hiding this comment.
VS2019 seems to be the first version to work with "${CMAKE_C_COMPILER_ID}" MATCHES "Clang". There is also a case where a LLVM compiler can be used with changes to VS paths, but it IDs as LLVM.
There was a problem hiding this comment.
From what I've seen on the interwebs, /fsanitize=address was only added in VS 2019 16.9.
https://devblogs.microsoft.com/cppblog/address-sanitizer-for-msvc-now-generally-available/
There was a problem hiding this comment.
Right, that is what we have on our test machines.
There was a problem hiding this comment.
Added check for MSVC version.
lrknox
approved these changes
Aug 11, 2021
lrknox
pushed a commit
that referenced
this pull request
Aug 17, 2021
lrknox
pushed a commit
that referenced
this pull request
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows clang name is clang-cl and windows flags do not use a dash.