Fixed the CMake processing for C++ warnings and flags #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
bmribler,
derobins,
lrknox and
qkoziol
as code owners
lrknox
approved these changes
Aug 11, 2021
derobins
reviewed
Aug 12, 2021
| NOT DEFINED CMAKE_CXX${CMAKE_CXX_STANDARD}_STANDARD_COMPILE_OPTION) | ||
| if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.13) | ||
| if (NOT CMAKE_CXX_STANDARD OR CMAKE_CXX_STANDARD EQUAL 98) | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++03") |
There was a problem hiding this comment.
Did you test this? C++11 is required in develop.
There was a problem hiding this comment.
This section was copied from a CMake file. That line is just setting the min to c++03 if CMAKE_CXX_STANDARD is not defined - we set that in line 14.
lrknox
pushed a commit
that referenced
this pull request
Aug 17, 2021
lrknox
added a commit
that referenced
this pull request
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.