Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get class name null str #899

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Conversation

seanm
Copy link
Contributor

@seanm seanm commented Aug 12, 2021

No description provided.

seanm and others added 2 commits August 12, 2021 10:34
Error message from MSVC with C++23 enabled:

error C2440: 'return': cannot convert from 'int' to 'std::basic_string<char,std::char_traits,std::allocator>'
@seanm
Copy link
Contributor Author

seanm commented Aug 12, 2021

This comes from here: InsightSoftwareConsortium/ITK#2684

@seanm
Copy link
Contributor Author

seanm commented Aug 20, 2021

@lrknox thanks! As this is a build error, probably best to backport to older branches too...

@lrknox lrknox merged commit 09283ff into HDFGroup:develop Aug 20, 2021
@lrknox
Copy link
Collaborator

lrknox commented Aug 20, 2021

@lrknox thanks! As this is a build error, probably best to backport to older branches too...

PRs #945, 946, 947 created and approved for 1.12, 1.10 and 1.8. I'll merge them after develop tests pass tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants