Develop windows compiler fixes #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore MS C++ Default exception handling behavior #885 Remove clang toolchain as it skips compiler checks
byrnHDF
requested review from
derobins,
fortnern,
jhendersonHDF,
jrmainzer,
lrknox,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
byrnHDF
commented
Aug 17, 2021
| @@ -631,6 +631,12 @@ | |||
| PTHREAD_SCOPE_SYSTEM) call. */ | |||
| #cmakedefine H5_SYSTEM_SCOPE_THREADS @H5_SYSTEM_SCOPE_THREADS@ | |||
|
|
|||
| /* Define using v1.6 public API symbols by default */ | |||
byrnHDF
commented
Aug 17, 2021
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -wd5105") | ||
| endif() | ||
| if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC" AND CMAKE_CXX_COMPILER_LOADED) | ||
| set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHsc") |
There was a problem hiding this comment.
Actual change - most other changes just whitespace
byrnHDF
commented
Aug 17, 2021
config/toolchain/clang.cmake
Outdated
| @@ -1,15 +1,15 @@ | |||
| # Uncomment the following to use cross-compiling | |||
| #set(CMAKE_SYSTEM_NAME Linux) | |||
|
|
|||
| set(CMAKE_COMPILER_VENDOR "clang") | |||
There was a problem hiding this comment.
This caused the compiler checks to be skipped. Left code in case a change is needed after extensive testing.
There was a problem hiding this comment.
I will revert this because the reason this change was based on was incorrect.
byrnHDF
commented
Aug 17, 2021
src/H5private.h
Outdated
| @@ -44,7 +44,9 @@ | |||
| #include <sys/time.h> | |||
| #endif | |||
| #ifdef H5_HAVE_UNISTD_H | |||
| #ifdef H5_HAVE_GETPWUID | |||
lrknox
approved these changes
Aug 19, 2021
derobins
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.