Correct dataset close in java test #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
derobins,
fortnern,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
| @@ -60,7 +60,7 @@ | |||
| #define MPICH_SKIP_MPICXX 1 | |||
| #endif | |||
| #ifndef OMPI_SKIP_MPICXX | |||
| #define OMPI_SKIP_MPICXX 1 | |||
| #define OMPI_SKIP_MPICXX 1 | |||
There was a problem hiding this comment.
Looks like this change is getting pulled into different PRs?
There was a problem hiding this comment.
yes, we let one get by and now it has snowballed!
lrknox
approved these changes
Aug 18, 2021
derobins
approved these changes
Aug 18, 2021
lrknox
pushed a commit
that referenced
this pull request
Aug 19, 2021
lrknox
pushed a commit
that referenced
this pull request
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.