Correction of pkg-config compile script. #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
bmribler,
derobins,
lrknox and
qkoziol
as code owners
lrknox
reviewed
Aug 30, 2021
release_docs/RELEASE.txt
Outdated
|
|
||
| It was discovered that the position of the "$@" location in the compile script | ||
| may fail on some platforms and configurations. This was moved before the | ||
| pkg-config sub command. |
There was a problem hiding this comment.
Suggestion to make the second sentence clearer - '"$@" was moved to a position before the pkg-config config sub command in the pkg-config compile script.'
lrknox
approved these changes
Aug 30, 2021
lrknox
approved these changes
Sep 1, 2021
derobins
approved these changes
Sep 7, 2021
lrknox
pushed a commit
that referenced
this pull request
Sep 18, 2021
lrknox
pushed a commit
that referenced
this pull request
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From spack issue.