Use separate Pylint steps in CI for hepdata_lib
and tests
directories
#267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hepdata_lib/.github/workflows/tests.yml
Lines 144 to 148 in ba9f2e2
I noticed in PR #265 that the CI is successful for commit 81adb42 (workflow run) despite the command
python -m pylint hepdata_lib/*.py
giving a exit code 8 with a message:Thus it looks like only the second command
python -m pylint tests/*.py
givingYour code has been rated at 10.00/10
(exit code 0) determines whether the "Run pylint" step passes or fails. The subsequent commit 51f13c1 (workflow run) gives issues for both thehepdata_lib
andtests
directories and the "Run pylint" step fails. This PR therefore separates the single "Run pylint" step into separate steps for thehepdata_lib
andtests
directories so that a code rating less than 10.00/10 (corresponding to a non-zero exit code forpylint
) for either directory will result in the CI failing.📚 Documentation preview 📚: https://hepdata-lib--267.org.readthedocs.build/en/267/