Fitting fixes jvb #389
Merged
Fitting fixes jvb #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelvbernier
added
enhancement
|
Hello @joelvbernier! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-02-15 04:00:42 UTC |
psavery
reviewed
Feb 14, 2022
joelvbernier
force-pushed
the
fitting-fixes-jvb
branch
from
2829029
to
cf8ab1b
Compare
psavery
approved these changes
Feb 14, 2022
|
Still needs unit tests, but I've tested it with an array of data including DCS. Also tested the updated "auto" powder calibration on a Pilatus. |
joelvbernier
force-pushed
the
fitting-fixes-jvb
branch
from
49a27b5
to
338ba17
Compare
joelvbernier
force-pushed
the
fitting-fixes-jvb
branch
from
338ba17
to
5caa07c
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new 1-d spectrum fitting module for calibration that uses
lmfit; this was really precipitated by the need to get the DCS pink beam function working. Constraints are essential. That use case is passing basic testing, but need to do several things:fitpeak@saransh13 and @darrencpagan -- I am open to any ideas you have regarding enhancing the initial parameter estimation. What we currently have is ok, but might not be robust if the initial guess is a bit further off. I am aware that there very well may not be a better generic rubric, but I figured I would plant the seed.