-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absorption correction #649
base: master
Are you sure you want to change the base?
Conversation
…ormula and density. Tested and fixed absorption correction for filterpack and sample+window layer.
…er correction tested. physics package correction needs to be tested.
…o test the transmission functions
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Hello @psavery! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-09-06 19:57:48 UTC |
Add missing dependency, fix an import, fix attribute name. Signed-off-by: Brianna Major <brianna.major@taloid.khq.kitware.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
=========================================
Coverage ? 30.29%
=========================================
Files ? 141
Lines ? 22947
Branches ? 0
=========================================
Hits ? 6952
Misses ? 15995
Partials ? 0 ☔ View full report in Codecov by Sentry. |
@@ -12,6 +12,7 @@ | |||
|
|||
install_reqs = [ | |||
'appdirs', | |||
'chemparse', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to add chemparse
as a conda dependency as well.
Signed-off-by: Brianna Major <brianna.major@taloid.khq.kitware.com>
f628914
to
7792abc
Compare
This adds a physics package class along with code to perform absorption corrections due to components of the physics package or components on the detectors.