Calibration testcases #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the expected output to match what the correct answers are for the simulated TARDIS. This also gets the lattice parameter to refine (it was already set to the ideal value before), and it removes the tilt refinements (we were refining too many things at once - this setup with just translations and materials seems to be working well). Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
|
Hello @psavery! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 33.49% 36.32% +2.83%
==========================================
Files 129 129
Lines 21237 21238 +1
==========================================
+ Hits 7113 7715 +602
+ Misses 14124 13523 -601 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.