Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try removing fabio pin #713

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Try removing fabio pin #713

merged 1 commit into from
Sep 5, 2024

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Sep 5, 2024

The CI seems to be failing because of this...

The CI seems to be failing because of this...

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
@psavery psavery marked this pull request as draft September 5, 2024 12:51
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.33%. Comparing base (5f1f4c5) to head (e461b5e).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage   33.50%   36.33%   +2.83%     
==========================================
  Files         129      129              
  Lines       21253    21254       +1     
==========================================
+ Hits         7120     7722     +602     
+ Misses      14133    13532     -601     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psavery psavery marked this pull request as ready for review September 5, 2024 14:50
Copy link
Collaborator

@donald-e-boyce donald-e-boyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@psavery psavery merged commit d63c57e into master Sep 5, 2024
8 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants