Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PowderCalibrator to the one in hexrd #1244

Merged
merged 2 commits into from
Jun 15, 2022

Commits on Jun 9, 2022

  1. Migrate PowderCalibrator to the one in hexrd

    We were previously using a custom PowderCalibrator class for the
    "Laue and Powder" calibration in hexrdgui. However, this class is
    not maintained and no longer works properly.
    
    Migrate over to using the PowderCalibrator from hexrd. This one
    is more maintained and updated.
    
    The migration required modifying the data input, since the
    PowderCalibrator from hexrd expects the input data to be in a different
    format.
    
    There may be some options we should be using and are not using yet.
    
    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    127f42b View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Make conversion to cartesian consistent

    Because the instrument gets updated for every iteration, the conversion
    to cartesian coordinates was being changed for every iteration. This
    would cause the least squares to diverge significantly.
    
    Fix it so that we use a consistent conversion to cartesian coordinates
    by using a copy of the original HEDMInstrument.
    
    This also makes a few small modifications so that it is more consistent
    with hexrd's InstrumentCalibrator.
    
    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    5307626 View commit details
    Browse the repository at this point in the history