Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default working dir the current directory #1634

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Dec 6, 2023

This fixes an issue where in many places in the code, we assume the working_dir to be a valid path. But if it is None, an exception is raised.

This fixes an issue where in many places in the code, we assume the working_dir
to be a valid path. But if it is `None`, an exception is raised.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
@psavery psavery requested a review from bnmajor December 6, 2023 18:01
Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@psavery psavery merged commit 77984c4 into master Dec 6, 2023
9 checks passed
@psavery psavery deleted the default-working-dir branch December 6, 2023 18:20
psavery added a commit that referenced this pull request Jan 1, 2024
This complements #1634

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants