Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-2681] Unfurl production PR links in slack notifications #2068

Merged
merged 20 commits into from
Apr 1, 2024

Conversation

kryswisnaskas
Copy link
Collaborator

@kryswisnaskas kryswisnaskas commented Mar 28, 2024

Description of change

This PR adds changes to unfurl links in slack when production PR notifications are received. Instead of incoming-webhooks chat:postMessage is used.

How to test

No tests needed.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • [n/a] Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions
  • [n/a] UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@kryswisnaskas kryswisnaskas marked this pull request as ready for review March 28, 2024 16:58
@kryswisnaskas kryswisnaskas reopened this Mar 28, 2024
@kryswisnaskas kryswisnaskas deleted the kw-github-slack branch March 28, 2024 17:34
@kryswisnaskas kryswisnaskas reopened this Mar 28, 2024
@kryswisnaskas kryswisnaskas reopened this Mar 29, 2024
@kryswisnaskas kryswisnaskas reopened this Mar 29, 2024
@kryswisnaskas kryswisnaskas changed the title Test expanding PR link in slack [TTAHUB-2681] Unfurl production PR links in slack notifications Mar 29, 2024
@kryswisnaskas kryswisnaskas merged commit 13ea512 into main Apr 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants