-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTAHUB-2681] Unfurl production PR links in slack notifications #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryswisnaskas
force-pushed
the
kw-github-slack
branch
from
March 29, 2024 17:08
61a8f77
to
1f29044
Compare
kryswisnaskas
requested review from
thewatermethod,
nvms,
hardwarehuman,
AdamAdHocTeam,
kcirtapfromspace and
GarrettEHill
March 29, 2024 20:08
kryswisnaskas
changed the title
Test expanding PR link in slack
[TTAHUB-2681] Unfurl production PR links in slack notifications
Mar 29, 2024
thewatermethod
approved these changes
Mar 29, 2024
AdamAdHocTeam
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR adds changes to unfurl links in slack when production PR notifications are received. Instead of incoming-webhooks chat:postMessage is used.
How to test
No tests needed.
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy