Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Merge dissimilar FEI goals, fix bugs with session objectives on RTR, add new field to session form #2075

Merged
merged 19 commits into from
Apr 3, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Apr 3, 2024

Description of change

  • 2664 Data merge and update per user request
  • 2510/2511 Add IST visit fields to session report form
  • 2769 Fix display of TR goal objectives on the RTR
  • 2770 Link to correct TR page from the RTR

How to test

For 2664, this is a data migration; the change won't be visible until the migration is run on production.

For 2510, 2511: the IST visit form on the session form, participants page, should be visible. Depending on the selection made there, certain fields will conditionally display

For 2769, this is a case that is only visible on prod, but you could contrive a case by completing a training report for a recipient with multiple grants, picking both of that recipient's grants on the TR, and viewing that goal on the RTR once the report is complete. This will also allow verification of 2770, as the link on the TR card will be updated to link to the "view" version of the Training report, not the edit form itself.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review April 3, 2024 15:51
@Jones-QuarteyDana Jones-QuarteyDana merged commit da200dd into production Apr 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants