-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prod] Merge dissimilar FEI goals, fix bugs with session objectives on RTR, add new field to session form #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imilar_fei_goals
[TTAHUB-2664] merge dissimilar goals into FEI goal
[TTAHUB-2510] Add IST visit dropdown to session form
…on-objectives [TTAHUB-2769/2770] Fixes for session objectives
Jones-QuarteyDana
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
How to test
For 2664, this is a data migration; the change won't be visible until the migration is run on production.
For 2510, 2511: the IST visit form on the session form, participants page, should be visible. Depending on the selection made there, certain fields will conditionally display
For 2769, this is a case that is only visible on prod, but you could contrive a case by completing a training report for a recipient with multiple grants, picking both of that recipient's grants on the TR, and viewing that goal on the RTR once the report is complete. This will also allow verification of 2770, as the link on the TR card will be updated to link to the "view" version of the Training report, not the edit form itself.
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy