Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Resolve issues found during pen test #2087

Merged
merged 27 commits into from
Apr 9, 2024
Merged

Conversation

thewatermethod
Copy link
Collaborator

Description of change

Ensure select fields on the AR & TR are escaped from arbitrary HTML before being saved

How to test

Essentially, to test you need to have credentials to our system and the technical knowledge to intercept the communication between the front and the back end. I used a tool called Postman, and was able to inject HTML into our database by watching the traffic and duplicating it. There are unit tests verifying this fix.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review April 9, 2024 12:26
@Jones-QuarteyDana Jones-QuarteyDana merged commit 7c2c761 into production Apr 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants