Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-3036] Filter out TR goals from similarity api #2232

Merged

Conversation

AdamAdHocTeam
Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam commented Jun 26, 2024

Description of change

We want to exclude TR goals for the similarity API. This change does two things:

  • Prevents goals with a createdVia of 'tr' from coming back via the API.
  • Delete's any TR goals that currently have merge suggestions but are NOT merged.

As of writing this there are currently no TR goals that have been merged.

How to test

  • Review the code.
  • Run the test.http test called '### given a text, compute similarities for this recipient' for a TR goal and recipient (nothing should come back).
  • Run the same test in the above step for a valid createdVia it should return results.
  • Run the migration make sure we no longer have any 'GoalSimilarityGroups' or 'GoalSimilarityGroupGoals' for non-merged TR goals.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

prepMigration,
} = require('../lib/migration');

module.exports = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just increment the version number of the goal similarity groups instead of doing this, that is what it's for

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops ok Ill just up the version instead.

@AdamAdHocTeam AdamAdHocTeam merged commit 700ad39 into main Jun 27, 2024
10 checks passed
@AdamAdHocTeam AdamAdHocTeam deleted the al-ttahub-3036-filter-out-tr-goals-from-similarity branch June 27, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants