Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-2907] Add "something went wrong" page #2242

Merged
merged 17 commits into from
Jul 10, 2024

Conversation

AdamAdHocTeam
Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam commented Jul 1, 2024

Description of change

This adds a "something went wrong" context page to the HUB.

Currently its hooked up to the retrieval on AR, Event, Session, and Goals.

How to test

  • Review the code.
  • Ensure we match the UX design.
  • Make sure we correctly display the relevant page for each error code type (404 vs 500) etc.
  • Test by changing handlers to throw various response codes.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@AdamAdHocTeam AdamAdHocTeam marked this pull request as ready for review July 3, 2024 18:43
@AdamAdHocTeam AdamAdHocTeam changed the title [TTAHUB-2907] Add something went wrong page [TTAHUB-2907] Add "something went wrong" page Jul 3, 2024
@thewatermethod
Copy link
Collaborator

  1. any unmatched route still renders the old "not found" page.
  2. We should probably also update the feature flag to render the new page instead of the old not found page (look at FeatureFlag.js to see what I mean)
  3. The home link is noticeably smaller than the other text on the page

Copy link
Collaborator

@thewatermethod thewatermethod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other pages that might need this: Groups, Communication Log, Recipient Record.

@AdamAdHocTeam AdamAdHocTeam merged commit 9fc14a2 into main Jul 10, 2024
10 checks passed
@AdamAdHocTeam AdamAdHocTeam deleted the al-ttahub-2907-something-went-wrong-comp branch July 10, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants