Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO JIRA] Keep sql and drop test files #2278

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

GarrettEHill
Copy link
Collaborator

Description of change

  • sql files are needed for the ssdi
  • testing files should not be on deployed env

How to test

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@GarrettEHill GarrettEHill marked this pull request as ready for review July 18, 2024 16:56
@@ -12,3 +12,5 @@ hses.zip
temp/
tests/
.tmp/
*.test.js
!*.sql
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this do it? Doesn't it need to be in the deploy config?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to chat gpt this should do it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh boy

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's deploy to sandbox?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GarrettEHill
Copy link
Collaborator Author

./build before

      1 .css
      1 .html
      2 .jpg
    943 .js
      2 .json
      2 .map
      3 .png
      1 .svg
     23 .ttf
      2 .txt
     18 .woff
     19 .woff2

./build after

      1 .css
      1 .html
      2 .jpg
    746 .js
      2 .json
      2 .map
      3 .png
      1 .svg
     23 .ttf
      2 .txt
     18 .woff
     19 .woff2

@GarrettEHill GarrettEHill merged commit a3ff0df into main Jul 18, 2024
11 checks passed
@GarrettEHill GarrettEHill deleted the gh/cfignore-keep-sql-drop-tests branch July 18, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants