Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prod] Include inactive grants withing 60 days; update TR imports, add resource use sparkline graph #2295

Merged
merged 145 commits into from
Aug 5, 2024
Merged

[Prod] Include inactive grants withing 60 days; update TR imports, add resource use sparkline graph #2295

merged 145 commits into from
Aug 5, 2024

Conversation

kryswisnaskas
Copy link
Collaborator

@kryswisnaskas kryswisnaskas commented Jul 31, 2024 •
edited by AdamAdHocTeam
Loading

Description of change

Includes inactive grants that fall within 60 day inactivation.

Create sparkline graph to replace default view of top 10 resources on the resource dashboard

Update TR imports:

  • Import and populate the POC in the form
  • Fix the audience field so it populates the form
  • Fix the event duration field so that it populates the "training type" field in the form
  • Add clear specifications to the admin import page so we have a reference for expected headings and content
  • Automatically populate the collaborators based on the National Center column in the import

Backup Retention:
Implementation of the following as part of the backup process:

  • All backups for the 0-30 days (This includes daily backups, deployment triggered backups, manually triggered backups).
  • Daily backups for 31-60 days
  • Monday daily backups + 1st & 15th of the month backups for for 61-90 days
  • 1st of the month for backups older then 90 days
    New features to the latest_backup.sh script
  • flag based options
  • listing of available files
  • requesting a specific file
  • download and verify
  • erase file from server

Code coverage (2691):

  • Increased the code coverage percentage.

How to test

Verify the application works as expected.

Confirm using the XSLX file attached to TTAHUB-3240 that the fields are imported correctly. You may need to massage the data slightly, which I expect an engineer will do when the training reports are imported.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • [n/a] Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions
  • [n/a] UI review complete

Before merge to main

  • [n/a] OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

nvms and others added 30 commits June 5, 2024 11:57
@nvms
rm src/lib/awsElasticSearch/
b5f9710
@nvms
cleanup
a966bed
@nvms
cleanup
b4840b3
@nvms
Merge branch 'jp/2698/tools-coverage' into jp/2691/lib-coverage
9bbfed0
@nvms
Merge branch 'jp/2698/tools-coverage' into jp/2691/lib-coverage
de4bfcf
@nvms
add tests for lockManager.
59c99dd
@nvms
unused
0407924
@nvms
rm redundant test
f3b454a
@nvms
comment unused code
998add6
@nvms
more unused code
420c1a5
@nvms
...more unused code
5196876
@nvms
add tests for queue.js
cca71c5
@nvms
overrideStatusCodeOnAuthRequired:
8848a00 
  - export so it can be unit tested
  - fix auth check:
    - adjusted the filter logic to correctly identify when authentication is required, ensuring 'auth' is properly considered based on the 'filtered' flag. This change ensures the function returns UNAUTHORIZED as expected when data includes auth-related entries.

unfortunately this commit appears to have changed the entirety of both
files due to the line-endings changing from Windows to UNIX style.
@nvms
fully test queue.js
939a244
@nvms
Merge branch 'jp/2698/tools-coverage' into jp/2691/lib-coverage
d3fd928
@nvms
test the one and only branch in s3
9b12d49
@nvms
semaphore coverage
bb287d7
@nvms
lockManager coverage
45fa357
@nvms
apiErrorHandler coverage
4b571c6
@nvms
migration coverage
bd38e30
@nvms
modelUtils coverage
47c156d
@nvms
Merge branch 'main' into jp/2691/lib-coverage
812438e
@nvms
getPersonnelField coverage
6f4b55b
@nvms
common coverage
d5da9fc
@nvms
Merge branch 'main' into jp/2691/lib-coverage
2967fb2
@nvms
fix merged tests
aa75b3d
@GarrettEHill
phase 1
fa6b2a1
@GarrettEHill
next try
53c325f
@GarrettEHill
a few changes
5e3f32e
@GarrettEHill
Update config.yml
84b1c4c
@kryswisnaskas kryswisnaskas changed the title [Prod] Fix medium security alert; include inactive grants; update unexpected imports [Prod] Include inactive grants withing 60 days; update TR imports Jul 31, 2024
thewatermethod and others added 21 commits July 31, 2024 16:56
@thewatermethod
Add top margin to graph lines
dd559bf
@GarrettEHill
add more macOS support, this time for downloading the zip
1dd9a5f
@GarrettEHill
Remove all the URL implementations
9d0799b
@GarrettEHill
Merge branch 'main' into TTAHUB-3060/url-publish
eabf7b5
@GarrettEHill
Update bin/latest_backup.sh
5952b4e
@GarrettEHill
Update bin/latest_backup.sh
4a080a1
@GarrettEHill
Update bin/latest_backup.sh
a827946
@GarrettEHill
Update bin/latest_backup.sh
6b0d8b7
@GarrettEHill
Update automation/ci/scripts/cf_lambda.sh
cf99e5c
@GarrettEHill
Update .circleci/config.yml
65d48b3
@GarrettEHill
Update automation/ci/scripts/cf_lambda.sh
53d1e80
@GarrettEHill
Update .circleci/config.yml
4c22a0c
@nvms
yarn audit
e1729a4
@GarrettEHill
Merge pull request #2287 from HHS/TTAHUB-3026/backup-retention
b7ef64e 
[TTAHUB-3026] Self Service Automation - Database Backup - backup retention
@GarrettEHill
Merge branch 'main' into TTAHUB-3060/url-publish
97dfb27
Fix historical duplicate args
07eaee6
@nvms
restore test state to pre-merge
cb438a9
@GarrettEHill
Merge pull request #2279 from HHS/TTAHUB-3060/url-publish
5dfd4c4 
[TTAHUB-3060] Self Service Automation - Database Backup - Phase 2: Publish production url in slack
@nvms
Merge pull request #2189 from HHS/jp/2691/lib-coverage
f7f48f1 
[TTAHUB-2691] src/lib, coverage >= 90%
@thewatermethod
Merge branch main into mb/TTAHUB-1457/resource-use-graph
55ed989
@thewatermethod
Merge pull request #2289 from HHS/mb/TTAHUB-1457/resource-use-graph
efdf06c 
[TTAHUB-1457] Create resource use sparkline graph
@thewatermethod thewatermethod changed the title [Prod] Include inactive grants withing 60 days; update TR imports [Prod] Include inactive grants withing 60 days; update TR imports, add resource use sparkline graph Aug 2, 2024
@AdamAdHocTeam AdamAdHocTeam marked this pull request as ready for review August 5, 2024 15:58
@Jones-QuarteyDana Jones-QuarteyDana merged commit 909be0e into production Aug 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jones-QuarteyDana Jones-QuarteyDana Jones-QuarteyDana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kryswisnaskas @Jones-QuarteyDana @nvms @GarrettEHill @thewatermethod @AdamAdHocTeam @hardwarehuman