[Issue #1937] Translate Loading component text #2186
Conversation
…al for non-search loading translation as well Fixes #1937
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 90.6% | 790/872 |
| 🟡 | Branches | 71.79% | 224/312 |
| 🟢 | Functions | 87.89% | 167/190 |
| 🟢 | Lines | 91.27% | 742/813 |
Test suite run success
178 tests passing in 54 suites.
Report generated by 🧪jest coverage report action from 7316673
| import React from "react"; | ||
|
|
||
| import Spinner from "src/components/Spinner"; | ||
|
|
||
| export default function Loading() { | ||
| // TODO (Issue #1937): Use translation utility for strings in this file | ||
| const t = useTranslations("Loading"); |
There was a problem hiding this comment.
| const t = useTranslations("Loading"); | |
| unstable_setRequestLocale("en"); | |
| const t = useTranslations("Loading"); |
There was a problem hiding this comment.
Making these changes causes the following error in Storybook:
Looks like this might not be needed at the component level?
https://next-intl-docs.vercel.app/docs/getting-started/app-router/with-i18n-routing#add-unstable_setrequestlocale-to-all-layouts-and-pages
| @@ -1,14 +1,16 @@ | |||
| import { useTranslations } from "next-intl"; | |||
| import React from "react"; | |||
There was a problem hiding this comment.
| import React from "react"; | |
| import { unstable_setRequestLocale } from "next-intl/server"; | |
| import React from "react"; |
|
Looks good, think you need to add |
Summary
Fixes #1937
Time to review: 5 mins
Changes proposed
Implemented the translation library for the text on the Search loading spinner
Context for reviewers
This component is currently under the Search page, but seems like we'd likely reuse it elsewhere. Since file moves are weird to PR and revert I wanted to get more input before moving stuff around.
Additional information
Tested by implementing Storybook for this component
