Commandline parser #50
Conversation
…er into nick-working
…. print stages of process
Nick working
|
Thanks for showing interest in the project. I'll forward this to HHsmithy. |
|
I think you have to scale down the hand parser console to make it similar to the TestApp so that it only tests the functionality of the parser. IMO adding extra projects that does not improve or extend the core library should not be included. |
|
HandAction.ActionNumber should only be used in parsing when you need sorting of the actions like with ipoker hh. If you need the actionnumbers you should number them outside the library or number them in HandHistoryParserFastImpl.ParseFullHandistory |
|
My only gripe is that the intention of the library is to get data that is easy to analyze. It is really hard to use the pure library for that purpose. I feel there needs to be a project that helps users use the library to generate datasets they can then add to a database of their choice. Otherwise, my concern is this is really hard for commandline savvy excel users to use, who are probably the best customers for this. Whatever the last word happy to run this as another project. I can refactor to only include the HandEvaluator in the library if that is of interest. |
|
I have not gotten a response from HHSmithy yet. Secondly, what I meant before is that we do not need the HandEvaluator, there is libraries out there for that. This is primarily a parsing library and my focus have been on making the parser super fast, making the outputs correct and validating the results so we don't process illogical hands. When you say that you want to generate datasets, what kind of datasets do you need. Do you want to analyze equities or actions performed by the players? |
|
Hey sorry about the delay on this @koooee and @ItalyToast . I'll get back to you soon |
convert raw logs to csv files with additional features via commandline